fix(release): use case-insensitive label matching in check_release#158
Merged
Conversation
## What/Why The old GitHub Actions `contains()` expression was case-insensitive, but the bash replacement introduced in #156 compared labels case-sensitively. Lowercase labels with `${PR_LABELS,,}` to preserve the original semantics. ## Proof it works actionlint and shellcheck both pass with no errors. ## Risk + AI role Low -- one-liner fix. AI-assisted (Claude Opus 4.6). ## Review focus Confirm `${PR_LABELS,,}` (bash 4+ lowercase expansion) works on the ubuntu-latest runner. Signed-off-by: jmeridth <jmeridth@gmail.com>
zkoppert
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Lowercase PR labels before matching in the
check_releasegate job to preserve the case-insensitive behavior of the original GitHub Actionscontains()expression replaced in #156.What/Why
The bash label check introduced in #156 compares case-sensitively, while the
contains()it replaced was case-insensitive. A consumer with a capitalized label (e.g.,Release) would silently stop getting releases.Proof it works
actionlintandshellcheckpass. The${PR_LABELS,,}bash 4+ expansion lowercases all label names before comparison.Risk + AI role
Low -- one-liner fix to a string comparison. AI-assisted (Claude Opus 4.6).
Review focus
Confirm bash 4+ lowercase expansion (
${var,,}) is available on theubuntu-latestGitHub Actions runner.Readiness Checklist
Author/Contributor